Skip to content

This PR Improve docs build ci #1336

Merged
msaroufim merged 4 commits into
pytorch:mainfrom
soot-bit:fix-doc-build
May 13, 2025
Merged

This PR Improve docs build ci #1336
msaroufim merged 4 commits into
pytorch:mainfrom
soot-bit:fix-doc-build

Conversation

@soot-bit

@soot-bit soot-bit commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR Improve docs build ci

Changes:

  • removed redundant dependencies (git, make, python3-venv) from the GitHub Actions workflow, as they are preinstalled on ubuntu-latest runners.
  • Removed deprecated panels_add_bootstrap_css
  • Created _static directory to resolve warnings.

Testing:

  • Verified locally with make html (no errors/warnings).

@netlify

netlify Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for pytorch-examples-preview ready!

Name Link
🔨 Latest commit ee68721
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/681539696d9bac0008377221
😎 Deploy Preview https://deploy-preview-1336--pytorch-examples-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dvrogozh
dvrogozh suggested changes May 2, 2025
View reviewed changes

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1333 already addressed docs build. This PR suggests some improvements on top. I think it's better to change PR title accordingly saying for example "Improve docs build ci"

Comment thread .github/workflows/doc-build.yml Outdated
Comment thread docs/source/conf.py Outdated
This was referenced May 2, 2025
Open
Closed
dvrogozh
dvrogozh reviewed May 2, 2025
View reviewed changes
Comment thread .github/workflows/doc-build.yml Outdated
dvrogozh
dvrogozh reviewed May 2, 2025
View reviewed changes
Comment thread docs/source/conf.py Outdated
dvrogozh
dvrogozh reviewed May 2, 2025
View reviewed changes

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created _static directory to resolve warnings.

You don't do that in the PR. Or that's done implicit?

Fix documentation build: GitHub Actions, Sphinx 5.3.0, and theme comp…

I suggest to change PR title to "Improved documentation ci build"

Comment thread docs/source/conf.py
@soot-bit soot-bit changed the title Fix documentation build: GitHub Actions, Sphinx 5.3.0, and theme comp… This PR Improve docs build ci May 3, 2025
@soot-bit soot-bit changed the title This PR Improve docs build ci This PR Improve docs build ci May 3, 2025
@dvrogozh

dvrogozh commented May 5, 2025

Copy link
Copy Markdown
Contributor

The _static directory was explicitly created in this PR to resolve sphinx warnings about missing paths.

You don't have this in your PR code change. Did you forget to amend?

@soot-bit

soot-bit commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

The _static directory was explicitly created in this PR to resolve sphinx warnings about missing paths.

You don't have this in your PR code change. Did you forget to amend?

image
its here ,

@dvrogozh

dvrogozh commented May 7, 2025

Copy link
Copy Markdown
Contributor

its here

I overlooked it. Thank you for pointing out.

dvrogozh
dvrogozh approved these changes May 7, 2025
View reviewed changes

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @msaroufim, can you, please, take a look on this PR?

@msaroufim msaroufim merged commit 7028a2e into pytorch:main May 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@msaroufim msaroufim msaroufim approved these changes
@dvrogozh dvrogozh dvrogozh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soot-bit @dvrogozh @msaroufim @facebook-github-bot